Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External contributors pr's always fail to upload code coverage resuilts #2431

Closed
faddat opened this issue Apr 21, 2023 · 1 comment
Closed

External contributors pr's always fail to upload code coverage resuilts #2431

faddat opened this issue Apr 21, 2023 · 1 comment

Comments

@faddat
Copy link
Contributor

faddat commented Apr 21, 2023

(not 100% sure this is the reaosn, we may just want to make this unconditional in ci)
@mmulji-ic
Copy link
Contributor

mmulji-ic commented Apr 24, 2023 •
edited
Loading

hi @faddat , quite often we get failures as well, I think its instability with the tool. We are planning to move fully to SonarCloud. When checking PR's for merging, I check whether its a test failure or an report upload failure, that we can re-run individually. I checked CodeCov and its seems for you https://github.com/cosmos/gaia/pull/2432/checks ran the required tests ok.

See #2436 , for CodeCov -> SonarCloud issue

@faddat faddat mentioned this issue Apr 25, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@faddat @mmulji-ic