From 04699980bf1efb5cda172e9d2e7050ab4d95db26 Mon Sep 17 00:00:00 2001 From: MD Aleem <72057206+aleem1314@users.noreply.github.com> Date: Mon, 11 Jan 2021 18:21:42 +0530 Subject: [PATCH 1/6] [docs] x/crisis - general audit and cleanup (#8269) * update docs * review changes Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> --- x/crisis/spec/01_state.md | 2 +- x/crisis/spec/02_messages.md | 7 +------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/x/crisis/spec/01_state.md b/x/crisis/spec/01_state.md index cbb949b0e327..581c79dc0e6d 100644 --- a/x/crisis/spec/01_state.md +++ b/x/crisis/spec/01_state.md @@ -14,5 +14,5 @@ with the standard gas consumption method. The ConstantFee param is held in the global params store. - - Params: `mint/params -> amino(sdk.Coin)` + - Params: `mint/params -> legacy_amino(sdk.Coin)` diff --git a/x/crisis/spec/02_messages.md b/x/crisis/spec/02_messages.md index 93a01aec2677..8634c8f9f506 100644 --- a/x/crisis/spec/02_messages.md +++ b/x/crisis/spec/02_messages.md @@ -11,12 +11,7 @@ corresponding updates to the state. Blockchain invariants can be checked using the `MsgVerifyInvariant` message. -```go -type MsgVerifyInvariant struct { - Sender sdk.AccAddress - InvariantRoute string -} -``` ++++ https://github.com/cosmos/cosmos-sdk/blob/v0.40.0-rc7/proto/cosmos/crisis/v1beta1/tx.proto#L14-L22 This message is expected to fail if: - the sender does not have enough coins for the constant fee From 1dca7eb715b7565bf342e95b8be48c0ed582fc3e Mon Sep 17 00:00:00 2001 From: MD Aleem <72057206+aleem1314@users.noreply.github.com> Date: Tue, 12 Jan 2021 16:54:06 +0530 Subject: [PATCH 2/6] Update x/crisis/spec/02_messages.md Co-authored-by: Amaury --- x/crisis/spec/02_messages.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x/crisis/spec/02_messages.md b/x/crisis/spec/02_messages.md index 8634c8f9f506..5dce6274091d 100644 --- a/x/crisis/spec/02_messages.md +++ b/x/crisis/spec/02_messages.md @@ -11,7 +11,7 @@ corresponding updates to the state. Blockchain invariants can be checked using the `MsgVerifyInvariant` message. -+++ https://github.com/cosmos/cosmos-sdk/blob/v0.40.0-rc7/proto/cosmos/crisis/v1beta1/tx.proto#L14-L22 ++++ https://github.com/cosmos/cosmos-sdk/blob/v0.40.0/proto/cosmos/crisis/v1beta1/tx.proto#L14-L22 This message is expected to fail if: - the sender does not have enough coins for the constant fee From fc5e7bc04423030f2bcdf33cf245f5d5e65787ff Mon Sep 17 00:00:00 2001 From: aleem1413 Date: Fri, 15 Jan 2021 18:24:10 +0530 Subject: [PATCH 3/6] review changes --- x/crisis/spec/03_events.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/x/crisis/spec/03_events.md b/x/crisis/spec/03_events.md index 5aef2078ebf9..90070e48286d 100644 --- a/x/crisis/spec/03_events.md +++ b/x/crisis/spec/03_events.md @@ -6,9 +6,9 @@ order: 3 The crisis module emits the following events: -## Handlers +## MsgServer -### MsgVerifyInvariance +### MsgVerifyInvariant | Type | Attribute Key | Attribute Value | |-----------|---------------|------------------| From 90b7133f21eb560686149402ba95c4ad260c25d8 Mon Sep 17 00:00:00 2001 From: MD Aleem <72057206+aleem1314@users.noreply.github.com> Date: Mon, 11 Jan 2021 18:21:42 +0530 Subject: [PATCH 4/6] [docs] x/crisis - general audit and cleanup (#8269) * update docs * review changes Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> --- x/crisis/spec/01_state.md | 2 +- x/crisis/spec/02_messages.md | 7 +------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/x/crisis/spec/01_state.md b/x/crisis/spec/01_state.md index cbb949b0e327..581c79dc0e6d 100644 --- a/x/crisis/spec/01_state.md +++ b/x/crisis/spec/01_state.md @@ -14,5 +14,5 @@ with the standard gas consumption method. The ConstantFee param is held in the global params store. - - Params: `mint/params -> amino(sdk.Coin)` + - Params: `mint/params -> legacy_amino(sdk.Coin)` diff --git a/x/crisis/spec/02_messages.md b/x/crisis/spec/02_messages.md index 93a01aec2677..8634c8f9f506 100644 --- a/x/crisis/spec/02_messages.md +++ b/x/crisis/spec/02_messages.md @@ -11,12 +11,7 @@ corresponding updates to the state. Blockchain invariants can be checked using the `MsgVerifyInvariant` message. -```go -type MsgVerifyInvariant struct { - Sender sdk.AccAddress - InvariantRoute string -} -``` ++++ https://github.com/cosmos/cosmos-sdk/blob/v0.40.0-rc7/proto/cosmos/crisis/v1beta1/tx.proto#L14-L22 This message is expected to fail if: - the sender does not have enough coins for the constant fee From 14e806a51355f6714187d84f1aaaa1b059822337 Mon Sep 17 00:00:00 2001 From: MD Aleem <72057206+aleem1314@users.noreply.github.com> Date: Tue, 12 Jan 2021 16:54:06 +0530 Subject: [PATCH 5/6] Update x/crisis/spec/02_messages.md Co-authored-by: Amaury --- x/crisis/spec/02_messages.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x/crisis/spec/02_messages.md b/x/crisis/spec/02_messages.md index 8634c8f9f506..5dce6274091d 100644 --- a/x/crisis/spec/02_messages.md +++ b/x/crisis/spec/02_messages.md @@ -11,7 +11,7 @@ corresponding updates to the state. Blockchain invariants can be checked using the `MsgVerifyInvariant` message. -+++ https://github.com/cosmos/cosmos-sdk/blob/v0.40.0-rc7/proto/cosmos/crisis/v1beta1/tx.proto#L14-L22 ++++ https://github.com/cosmos/cosmos-sdk/blob/v0.40.0/proto/cosmos/crisis/v1beta1/tx.proto#L14-L22 This message is expected to fail if: - the sender does not have enough coins for the constant fee From adbca37accbf297d6eebf01e1b0ec5fa8b19d8e5 Mon Sep 17 00:00:00 2001 From: aleem1413 Date: Fri, 15 Jan 2021 18:24:10 +0530 Subject: [PATCH 6/6] review changes --- x/crisis/spec/03_events.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/x/crisis/spec/03_events.md b/x/crisis/spec/03_events.md index 5aef2078ebf9..90070e48286d 100644 --- a/x/crisis/spec/03_events.md +++ b/x/crisis/spec/03_events.md @@ -6,9 +6,9 @@ order: 3 The crisis module emits the following events: -## Handlers +## MsgServer -### MsgVerifyInvariance +### MsgVerifyInvariant | Type | Attribute Key | Attribute Value | |-----------|---------------|------------------|