Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the x/gov MsgSubmitProposal cost and don't delete dead proposals. #9683

Closed
4 tasks
robert-zaremba opened this issue Jul 12, 2021 · 4 comments · Fixed by #9995
Closed
4 tasks

Increase the x/gov MsgSubmitProposal cost and don't delete dead proposals. #9683

robert-zaremba opened this issue Jul 12, 2021 · 4 comments · Fixed by #9995
Assignees

Comments

@robert-zaremba
Copy link
Collaborator

Summary

Currently proposals which are inactive (still in deposit phase) and didn't get into active queue (voting phase) are deleted and the deposit is burned. Let's call the deleted inactive proposals as ghost.

ref: #9519 (comment)

Problem Definition

  • Ghost proposals are note queryable - it's fine - when a inactive proposal is deleted we emit an InactiveProposal event with AttributeValueProposalDropped attribute. No need to spam the network
  • however, the inactive proposals are queried during all blocks (x/gov EndBlocker) and nobody is paying for that

Proposal

Increase a cost of MsgSubmitProposal to pay for the future query in EndBlocker. We don't need to make it expensive. Consuming extra gas should be sufficient: x * storage_byte_cost * proposal_bytes_size , where x is something like 3-5.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added this to the v0.44 milestone Jul 12, 2021
@robert-zaremba
Copy link
Collaborator Author

@alexanderbez - in fact I've changed my mind - we can remove the inactive proposals because we have events for them (but don't have a strong opinion here, we can keep them as well). However argument to make the transaction more expensive stays - so I propose to increase the consumed gas in MsgSubmitProposal.

@aaronc , @clevinson - I've added it to 0.44, if we only increase the gas then it's very easy and don't break the UX.

@alexanderbez
Copy link
Contributor

If we also remove inactive proposals, we don't iterate over them in x/gov EndBlock, right? If that's the case, what is the argument for making those txs more expensive (not saying I'm against it)?

@robert-zaremba
Copy link
Collaborator Author

We remove inactive proposals in x/gov End Block (when iterating over inactive proposals queue).

@alexanderbez
Copy link
Contributor

alexanderbez commented Sep 9, 2021

ACK on the proposal. Another approach is to have a minimum self-deposit (param) when submitting a MsgSubmitProposal message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants