Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC: fix reflection service #8927

Closed
4 tasks
fdymylja opened this issue Mar 18, 2021 · 0 comments · Fixed by #8945
Closed
4 tasks

gRPC: fix reflection service #8927

fdymylja opened this issue Mar 18, 2021 · 0 comments · Fixed by #8945
Assignees
@fdymylja
Labels
C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. T:Bug
Milestone
v0.43

Comments

@fdymylja
Copy link
Contributor

fdymylja commented Mar 18, 2021 •
edited
Loading

Summary of Bug

The gRPC reflection server does not work as it is not querying the gogoproto registry (which is used in generated file to register file descriptors) but the proto one.

Version

Steps to Reproduce

By installing grpc-curl, it's possible to list services, but symbol resolution fails.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@fdymylja fdymylja self-assigned this Mar 18, 2021
@jgimeno jgimeno added this to the v0.43 milestone Mar 18, 2021
@jgimeno jgimeno mentioned this issue Mar 22, 2021
Merged
9 tasks
@fdymylja fdymylja changed the title gRPC: fix and extend reflection service gRPC: fix reflection service Mar 22, 2021
@amaury1093 amaury1093 added T:Bug C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. labels Mar 22, 2021
@mergify mergify bot closed this as completed in #8945 Mar 22, 2021
@aaronc aaronc removed the in-review label Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fdymylja fdymylja

Labels
C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. T:Bug
Projects
None yet
Milestone
v0.43
Development

Successfully merging a pull request may close this issue.

gRPC: fix server reflection cosmos/cosmos-sdk
5 participants
@aaronc @clevinson @amaury1093 @jgimeno @fdymylja