You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When starting up an internal testnet, we used an existing genesis file to import existing accounts and then added account balances to the genesis file using the gaiad add-genesis-account.
Two things turned out wrong:
adding the account balances did not update the total supply
running validate-genesis which resides in genutil, does basic validation of the genesis which results in a simple check if the supply is a valid sdk coin. Our genesis file with an incorrect total supply successfully passed validation
Solution
Adding a genesis account should update the total supply. Running genesis validation should check that all the account balances equal the total supply
Part of this may be a cosmos/gaia issue, but the supply validation is definitely an SDK issue
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
@colin-axner We're looking to cut v0.40.2 next week for an updated hub proposal. Do you think this will get resolved in time, or should we punt to the next v0.40.x point release.
Adding a genesis account should update the total supply. Running genesis validation should check that all the account balances equal the total supply
The balance vs supply check is already done by the invariant during init genesis (although not on validation). We just need to add the acc balance to the supply on genesis acc creation
Summary of Bug
When starting up an internal testnet, we used an existing genesis file to import existing accounts and then added account balances to the genesis file using the
gaiad add-genesis-account
.Two things turned out wrong:
Solution
Adding a genesis account should update the total supply. Running genesis validation should check that all the account balances equal the total supply
Part of this may be a cosmos/gaia issue, but the supply validation is definitely an SDK issue
For Admin Use
The text was updated successfully, but these errors were encountered: