-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grpc-web proxy for non-http2 clients #7345
Comments
What is a gRPC web proxy in this context and how does it differ from the gRPC HTTP gateway? |
I know this sounds like a nice feature to add, but I would be hesitant to add yet another server until there is a clear need (please link the client side project that cannot work without this). Every additional server is more ops overhead, as well as code maintenance. grpc-web supports all modern browsers (since early 2019 or so) and uses HTTP/2.0. It does everything according to the grpc spec except client side streaming, which I doubt we use (and definitely would not be supported by the web proxy). How about some explanation of concrete use cases here? |
I think there's some confusion in the title, we are adding exactly the grpc-web you linked. Their README lists these 2 items:
It's the first one that aleem's implementing in #8077. Somehow we still call it "proxy". |
I wasn't aware HTTP2 was supported by 95% of browsers today. In this case, can a browser talk directly to a gRPC server (I thought no)? If yes, why do we even need grpc-web? |
Ah, re-reading the docs. Maybe that is needed for HTTP/2.0 as well. I would be interesting to test this out sometime. With CosmJS, we use the grpc types but talk directly to tendermint rpc, as that is well defined and working since rc1 and before. We have no bandwidth to test out the grpc server with this, but if someone from your team does, you can probably use most of the types from it, and I'm sure you can get some pointers on discord. |
Create flag (enabled by default) to launch the grpc-web proxy for non-HTTP2 grpc web clients
Ref #5921
The text was updated successfully, but these errors were encountered: