-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate remaining CLI cmd's to proto #6987
Comments
x/gov
, x/upgrade
cli queries to use proto
I don't have IBC test data to do that @fedekunze. Once #6999 is done, you just need to try to use |
@alexanderbez cosmos-sdk/x/auth/client/query.go Line 46 in 20c80cf
One option I can think of is fetch all data, and paginate in sdk to act similar to other queries. Any thoughs? cc @aaronc @anilcse |
I would honestly opt to use Tendermint's pagination when it comes to tx searching. I don't think getting all txs behind the scenes is a good strategy. |
@anilcse can you provide a written update for this issue here? |
A few cli commands are still using amino or couldn't be easily migrated to use the proto pathway. These were discovered and flagged in #6859. Migrate them to use proto.
GetCmdSubmitProposal
->ParseCommunityPoolSpendProposalJSON
Migrate missingx/distribution
CLI queries to proto #7244NewWithdrawAllRewardsCmd
Migrate missingx/distribution
CLI queries to proto #7244Any
) /cc @fedekunzeclient.Context.PrintOutputLegacy
(from Require proto.Message in client.Context.PrintOutput #6999)The text was updated successfully, but these errors were encountered: