Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename *codec.Codec to *codec.LegacyAmino #6986

Closed
aaronc opened this issue Aug 7, 2020 · 3 comments · Fixed by #6991
Closed

Rename *codec.Codec to *codec.LegacyAmino #6986

aaronc opened this issue Aug 7, 2020 · 3 comments · Fixed by #6991

Comments

@aaronc
Copy link
Member

aaronc commented Aug 7, 2020

This type is now used only when we want to explicitly support legacy amino scenarios (queriers, REST). It is the type that should be used explicitly for these legacy scenarios. Eventually, even JSONMarshaler will need to require proto (see #6982). But for the cases we still really need amino we can use *codec.Codec. But let's give it a clear name, I propose *codec.LegacyAmino.

While we're doing this we should rename appropriate fields, specifically client.Context.Codec and simapp.Codec() should become *****.LegacyAmino.

@aaronc aaronc added this to the v0.40 [Stargate] milestone Aug 7, 2020
@alexanderbez
Copy link
Contributor

ACK

@dauTT
Copy link
Contributor

dauTT commented Aug 7, 2020

Hi, can I work on this?

@aaronc
Copy link
Member Author

aaronc commented Aug 7, 2020

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants