-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an ability to update ConsensusParams #6197
Comments
The SDK now manages consensus parameters via the x/params module and are changed via governance proposals. That being said, we should probably figure out if we need to send these to Tendermint at all. Do we need to @marbar3778 @melekes ? |
yes they should be sent to Tendermint. If not then while the application changes the params the Tendermint logic will adhere to the genesis consensus params and this may cause problems |
Any schedule to handle this issue? |
Add this to #6365 as it should be done prioir to the next major release |
What do you mean @marbar3778 -- this was already done. #5952 |
ah based off this comment I thought it wasn't |
As @marbar3778 said, this issue is not done. I agree with him. |
What do you mean it's not done? I pointed to the PR that completes the work => #5952 |
ConsensusParams should be updated in Endblock via:
This is not implemented yet. |
Summary
Adding an ability to update ConsensusParams by collecting ConsensusParamUpdates from
Module.EndBlock
.Problem Definition
Updating
ConsensusParams
can be done by passing changes to Tendermint through ResponseEndBlock.We can decide whether to change using the governance module.
However, ModuleManager does not collect
ConsensusParamUpdates
nor passes them to Tendermint because the interface ofAppModule.EndBlock
returns only ValidatorUpdate.cosmos-sdk/types/module/module.go
Lines 312 to 334 in 80be503
Proposal
AppModule.EndBlock
returns ConsensusParamUpdates also.For Admin Use
The text was updated successfully, but these errors were encountered: