-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST /txs "tx.minheight" parameter does nothing, invalidates the query #5845
Comments
/cc @gagbo |
Directly querying Tendermint's curl -X GET "http://localhost:26657/tx_search?query=tx.height%3E%3D1&prove=false&page=1&per_page=100&order_by=desc" -H "accept: application/json" Result: {
"jsonrpc": "2.0",
"id": -1,
"error": {
"code": -32602,
"message": "Invalid params",
"data": "error converting http params to arguments: invalid character 'x' in literal true (expecting 'r')"
}
} curl -X GET "http://localhost:26657/tx_search?query=tx.height%3D1&prove=false&page=1&per_page=100&order_by=desc" -H "accept: application/json" Result: {
"jsonrpc": "2.0",
"id": -1,
"error": {
"code": -32602,
"message": "Invalid params",
"data": "error converting http params to arguments: invalid character 'x' in literal true (expecting 'r')"
}
} |
This is actually implemented in #5648, but https://cosmos.network/rpc/#/ already lists it, so I thought it was be available in 0.38.1. Turns out I was wrong. |
I had the same weird surprise. The swagger lists it but it's not actually in the code. For reference, 0.37.8 has the backport, No idea about 0.38 versions though |
Summary of Bug
The REST endpoint
/txs
accepts a given variety of parameters explained here.The
tx.minheight
parameter should be used to filter transaction happened after a given block height.Including said parameter in a REST call result in an empty result:
Version
Cosmos-SDK v0.38.1
Steps to Reproduce
For Admin Use
The text was updated successfully, but these errors were encountered: