Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet timeout height should be compared with local consensus height #5466

Closed
cwgoes opened this issue Jan 2, 2020 · 5 comments
Closed

Packet timeout height should be compared with local consensus height #5466

cwgoes opened this issue Jan 2, 2020 · 5 comments

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jan 2, 2020

0cc893b8-5aee-4249-be3e-a2be0ddcaddb

(reported via Telegram)

cc @fedekunze

@PumpkinSeed
Copy link
Contributor

PumpkinSeed commented Jan 2, 2020

I would like to give it a try tomorrow. Is there any details about?

@cwgoes
Copy link
Contributor Author

cwgoes commented Jan 2, 2020

I would like to give it a try tomorrow. Is there any details about?

That would be fantastic! The local height (ctx.BlockHeight() I believe) should be used instead.

@fedekunze
Copy link
Collaborator

Closed via #5462. Sorry @PumpkinSeed I didn't notice you wanted to work on it. Do you want to contribute to the IBC implementation (ibc-alpha branch)? One thing that's missing is increasing the code coverage with unit tests (especially on the xibc/<XX-XXX>/types directories). That should give you a high-level understanding of the core components of the protocol.

@PumpkinSeed
Copy link
Contributor

Do you want to contribute to the IBC implementation (ibc-alpha branch)? One thing that's missing is increasing the code coverage with unit tests (especially on the xibc/<XX-XXX>/types directories). That should give you a high-level understanding of the core components of the protocol.

Yes. Just to avoid misunderstands, can you tell me which issue belongs to it?

@fedekunze
Copy link
Collaborator

#5470 @PumpkinSeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants