Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ocaps for Module accounts' bank #4546

Closed
fedekunze opened this issue Jun 13, 2019 · 1 comment
Closed

Create ocaps for Module accounts' bank #4546

fedekunze opened this issue Jun 13, 2019 · 1 comment
Assignees

Comments

@fedekunze
Copy link
Collaborator

fedekunze commented Jun 13, 2019

This structure should be changed to reduce the capability of the a module is able to do. A holder module should only be able to:

  • send tokens from it's module account to another module account or regular wallet account
  • take tokens from a regular wallet account to it's module account

In the provided design modules are able to send or take to any module account - this is a clear opportunity for modules to be improperly designed (or opportunity for malicious modules).

Originally posted by @rigelrozanski in #4255 (comment)

@fedekunze
Copy link
Collaborator Author

closed via #4255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants