-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile stabilization and updates #2672
Comments
Lets go ahead and implement this! |
The first PR is about Windows compatibility for the build target and ledger support. It does not address the issue of |
The second PR was submitted with a cross-OS compatible Unfortunately, the first PR was not merged yet, so the whole thing is pending on review now. The good news is that it was tested on OSX and Windows and CircleCI ran it successfully for Linux. |
Closing this issue. The merged PR resolves all conflicts for Windows builds. |
Summary
Makefile
compile for Windows (required for SRE OKR binary signing)Problem Definition
The current
Makefile
'sledger_check
target executes even when the target is not called. Along with similar discrepancies, theMakefile
does not run on Windows. It has to, if we want to build Voyager with gaiad for Windows, which is a launch requirement.Proposal
check_ledger
target to make it run only when it's called.get_tools
target to be compatible with Windows.build
target on Windows: Version information is lost,gaiad.exe version
returns an empty string.update_gaia_lite_docs
optional for thebuild
target. (don't runupdate_gaia_lite_docs
onbuild
#2647)For Admin Use
The text was updated successfully, but these errors were encountered: