Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated block field from BlockByHeightResponse and LatestBlockResponse #23364

Open
rootulp opened this issue Jan 13, 2025 · 1 comment
Open

Remove deprecated block field from BlockByHeightResponse and LatestBlockResponse #23364

rootulp opened this issue Jan 13, 2025 · 1 comment
Labels
needs-triage Issue that needs to be triaged

Comments

@rootulp
Copy link
Contributor

rootulp commented Jan 13, 2025

Context

celestiaorg/celestia-app#4204 (comment) and #11390

Problem

#11390 deprecated the block field in the BlockByHeightResponse but it hasn't been removed yet. Since both block and sdk_block are returned in the response, if a block has 7 MiB of txs then the response has 14 MiB of txs.

Proposal

Remove the block field in BlockByHeightResponse and LatestBlockResponse. Note this is a breaking change.
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jan 13, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Jan 13, 2025
@julienrbrt
Copy link
Member

We cannot remove the field from the proto, as we cannot have proto breaking changes. However, stop filling the field is definitely an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage Issue that needs to be triaged
Projects
Cosmos-SDK
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rootulp @julienrbrt