Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle the case when a bonded validator decreases below the power of the cliff validator #2071

Closed
cwgoes opened this issue Aug 16, 2018 · 2 comments
Closed

Correctly handle the case when a bonded validator decreases below the power of the cliff validator #2071

cwgoes opened this issue Aug 16, 2018 · 2 comments
Assignees
@rigelrozanski @cwgoes
Labels
C:x/staking T:Bug

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Aug 16, 2018

Presently, if we call UpdateBondedValidators with a previously bonded validator now lower in power than the current cliff validator, we will bond a new validator (just after the old cliff validator) but unbond the cliff validator, when we should have unbonded the previously bonded validator instead!

Caught by randomized simulation.

Ref 238458a#diff-dfc120ab4c4b55ca9500442fe7d7287fR481, not a complete fix.
@cwgoes cwgoes mentioned this issue Aug 16, 2018
Closed
@cwgoes
Copy link
Contributor Author

cwgoes commented Aug 16, 2018

Let's fix this in a single PR with only the fix against the release branch, including a testcase isolating the issue.

@alexanderbez alexanderbez mentioned this issue Aug 17, 2018
Merged
9 tasks
@cwgoes
Copy link
Contributor Author

cwgoes commented Aug 18, 2018

Fixed by #2083.

@cwgoes cwgoes closed this as completed Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rigelrozanski rigelrozanski

@cwgoes cwgoes

Labels
C:x/staking T:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rigelrozanski @cwgoes