[Bug]: multisign outputs key not provided

[JulianToledano]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

The multisign command now outputs the following message: 'No key name or address provided; using the default key: alice.'

This could potentially break scripts that use the redirect operator, although not a significant issue as those can always be updated to use --output-document. Main issue is it provides misleading information, as multisig key name is a required argument for the command.

Cosmos SDK Version

main

How to reproduce?

tx multi-sign... (without using --from flag)

[julienrbrt]

That's actually a feature more than a bug. Whenever flag --from is required, but no key is provided, we fallback to the default from client.toml. if the default in client.toml is empty, it will fail like before.
We happen to have a default in simapp for showing the capability and facilitate testing but other chains won't.
The user would have to purposely enter a default key.

[julienrbrt]

For reference: #18101

[JulianToledano]

Whenever flag --from is required, but no key is provided, we fallback to the default from client.toml.

I see although as shown by the command help:
simd tx multi-sign [file] [name] [[signature]...] [flags]

The name of the key is a required argument but not the --from flag. Maybe we could change that just leave the file as argument and check --from has been set?

[julienrbrt]

I see, then it's a bug indeed. I don't think we should change the command UX.
We could set the from like we did in bank before autocli: https://github.com/cosmos/cosmos-sdk/blob/release/v0.50.x/x/bank/client/cli/tx.go#L50