x/staking/keeper: AppHash depends on non-deterministic block time

[elias-orijtech]

When simulating, it's useful to ensure that the AppHash stays the same across multiple runs. However, at least this store,

cosmos-sdk/x/staking/keeper/historical_info.go

Line 46 in 6af7f30

time := sdkCtx.HeaderInfo().Time

makes the AppHash depend on the block time, which is non-deterministic when running on top of testutil/network.Network.

This may not be a bug per se, but limits the determinism of the simulator. I'll bring this issue up in tomorrow's meeting, @alexanderbez, @odeke-em , @tac0turtle .

[tac0turtle]

this is done from the time set by comet or the underlying consensus engine. In order to make it consistent we would need to inject a consist time, not sure if that is possible?

[elias-orijtech]

Closing this is favor of #18145 (mocking comet for testutil/network).