You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(The objection here was only because the struct definition was nested)
And it noticed that some json tags were broken, we had: client/tx/sign.go:14::error: struct field tag json="name"``
it should have been json:"name".
I think it may be useful, but I don't feel strongly about it. (The main benefit being it catching the second bug) We currently spend alot of reviews making nitpicks on stuff that a linter in principle could catch,
Optionally, we can turn off its composite literal check, since I think thats the least impactful of the things it provides. (I personally like it, but I don't want that being annoying to detract from what else it can help with)
The text was updated successfully, but these errors were encountered:
Do we want to use go vet in the linter? Here are some sample things it wants to fix:
to
(The objection here was only because the struct definition was nested)
And it noticed that some json tags were broken, we had:
client/tx/sign.go:14::error: struct field tag
json="name"``it should have been
json:"name"
.I think it may be useful, but I don't feel strongly about it. (The main benefit being it catching the second bug) We currently spend alot of reviews making nitpicks on stuff that a linter in principle could catch,
Here's the golang page describing govet: https://golang.org/cmd/vet/
Optionally, we can turn off its composite literal check, since I think thats the least impactful of the things it provides. (I personally like it, but I don't want that being annoying to detract from what else it can help with)
The text was updated successfully, but these errors were encountered: