From 1cab2bc7f4572c07e47d7b5fe97bfd91183d6960 Mon Sep 17 00:00:00 2001 From: Jacob Gadikian Date: Tue, 9 Aug 2022 02:43:57 +0700 Subject: [PATCH] ci: Use go 1.19 for proto build environment (#12854) * Update Dockerfile * Update proto-docker.yml * Update Dockerfile * Update proto-docker.yml * Update proto-docker.yml * Update CHANGELOG.md * Update .github/workflows/proto-docker.yml Co-authored-by: Marko * Update proto-docker.yml Co-authored-by: Marko Co-authored-by: Marko --- .github/workflows/proto-docker.yml | 21 ++++++++++++++------- CHANGELOG.md | 1 + contrib/devtools/Dockerfile | 3 ++- 3 files changed, 17 insertions(+), 8 deletions(-) diff --git a/.github/workflows/proto-docker.yml b/.github/workflows/proto-docker.yml index dbab7a21cc05..fb4af6ae130c 100644 --- a/.github/workflows/proto-docker.yml +++ b/.github/workflows/proto-docker.yml @@ -4,7 +4,10 @@ on: branches: - main paths: - - "contrib/devtools/dockerfile" + - "contrib/devtools/Dockerfile" + pull_request: + paths: + - "contrib/devtools/Dockerfile" permissions: contents: read @@ -31,16 +34,20 @@ jobs: - name: Set up Docker Buildx uses: docker/setup-buildx-action@v2 - - name: Login to DockerHub - uses: docker/login-action@v2 + - name: Login to GitHub Container Registry + uses: docker/login-action@v2 + if: ${{ github.event_name != 'pull_request' }} with: - username: ${{ secrets.DOCKERHUBTM_USERNAME }} - password: ${{ secrets.DOCKERHUBTM_TOKEN }} + registry: ghcr.io + username: ${{ github.repository_owner }} + password: ${{ secrets.GITHUB_TOKEN }} + - - name: Publish to Docker Hub + - name: Publish to GHCR uses: docker/build-push-action@v3 with: context: ./contrib/devtools platforms: linux/amd64,linux/arm64 - push: true + push: ${{ github.event_name != 'pull_request' }} tags: ${{ steps.prep.outputs.tags }} + name: ghcr.io/cosmos/proto-builder diff --git a/CHANGELOG.md b/CHANGELOG.md index cad0d2cfd9e5..694bb1cef6bb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -45,6 +45,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ ### Improvements +* (ci) [#12854](https://github.com/cosmos/cosmos-sdk/pull/12854) Use ghcr.io to host the proto builder image. Update proto builder image to go 1.19 * (x/bank) [#12706](https://github.com/cosmos/cosmos-sdk/pull/12706) Added the `chain-id` flag to the `AddTxFlagsToCmd` API. There is no longer a need to explicitly register this flag on commands whens `AddTxFlagsToCmd` is already called. * [#12791](https://github.com/cosmos/cosmos-sdk/pull/12791) Bump the math library used in the sdk and replace old usages of sdk.* * (x/params) [#12615](https://github.com/cosmos/cosmos-sdk/pull/12615) Add `GetParamSetIfExists` function to params `Subspace` to prevent panics on breaking changes. diff --git a/contrib/devtools/Dockerfile b/contrib/devtools/Dockerfile index 05bed5ac81bf..d5f4469dc435 100644 --- a/contrib/devtools/Dockerfile +++ b/contrib/devtools/Dockerfile @@ -4,7 +4,8 @@ FROM bufbuild/buf:1.1.0 as BUILDER -FROM golang:1.18-alpine +FROM golang:1.19-alpine + RUN apk add --no-cache \ nodejs \