-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for subscriptions #49
Comments
Apparently it is not possible to subscribe with the rest server, only via tendermint rpc. Got this response from a lunie wallet dev:
|
Let's just do polling like in the Lisk connector. That brought us quite far and is way more stable than websockets. |
Okay |
What would also work is a hybrid, where you use a tendermint socker subscribtion to get notified about new data. When you receive a new transaction, you ignore the amino data and pull via REST. |
Yes, I like this. I think we did some of this at iov. Just have a stream of "update happened" from the subscription service. And those events trigger a rest call to get the data. I can look into proper tendermint subscription queries, but that would also require a second url and connection (maybe optional?) |
For wallet integration we need |
Closing since the BCP implementation is moving out of here and subscriptions will get their comeback in a couple of weeks when we successfully communicate with Tendermint. |
We should expose some sort of subscription listener to the RestClient and use it in the CosmWasmConnection. In particular, for full bcp-compatibility, we need to implement:
watchBlockHeaders
watchAccount
And
postTx
could be done nicer with a subscription that with a poll.I believe these are needed for dropping in
CosmWasmConnection
into the iov-walletThe text was updated successfully, but these errors were encountered: