Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Cortex fingerprint mapper #1871

Open
cyriltovena opened this issue Dec 3, 2019 · 2 comments
Open

Refactor Cortex fingerprint mapper #1871

cyriltovena opened this issue Dec 3, 2019 · 2 comments
Labels
help wanted

Comments

@cyriltovena
Copy link
Contributor

The current fingerprint mapper is not meant to be used externally, but we are facing the same issue in Loki.

For now we copied code over and adapted it for Loki, but I think it would better to refactor the mapper by making it public and less dependent on Cortex code.

see grafana/loki#1247
@stale
Copy link

stale bot commented Feb 3, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 3, 2020
@pracucci pracucci added keepalive Skipped by stale bot and removed stale labels Feb 3, 2020
@pstibrany
Copy link
Contributor

Good idea, PR is welcome!

@pracucci pracucci added help wanted and removed keepalive Skipped by stale bot labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pstibrany @cyriltovena @pracucci