Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantity Price Rules (Tier Pricing) #790

Closed
solverat opened this issue Jan 25, 2019 · 5 comments
Closed

Quantity Price Rules (Tier Pricing) #790

solverat opened this issue Jan 25, 2019 · 5 comments
Assignees
Milestone

Comments

@solverat
Copy link
Contributor

solverat commented Jan 25, 2019

Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? yes

Features

  • Build tier prices based on specific rules
  • Define different pricing behaviors (new fixed price, discount amount, amount increase, discount percentage, percentage increase)
  • Define pseudo price for each range
  • Allow inheriting on variants
  • Highlight specific range price
  • Copy / paste ranges in different tier price rules

To-Do / To Discuss

  • Should we implement a "calculation strategy" registry? I'm thinking about caclulation prices in tier ranges or volume ranges for example (read more about here. Could it be implemented later on without any BC breaks if we keep it as it is? -> Done: Calculators
  • What about units? Currently coreshop does not work and allow unit strategies and is a different (new) feature for sure. But we need to consider a practicable way how to calculate tier pricing based on items/units for example.: -> comes with Sale Unit #837 😄

PR: #791

@solverat
Copy link
Contributor Author

This PR will also fix some rule issues / glitches:

  • global rule condition does not get deleted after it has been removed from condition tab (extjs rendering issue)
  • specific price rule: non-active icon rendering fails if multiple rules has been created (extjs rendering issue)
  • remove console.log debug line
  • improve setActiveItem execution
  • critical: if there are more than one specific price rules: re-open object, save: error (extjs rendering issue)

@solverat
Copy link
Contributor Author

issue description updated.

@solverat
Copy link
Contributor Author

solverat commented Jan 31, 2019

Backend:

bildschirmfoto 2019-01-31 um 18 43 29

Frontend:

bildschirmfoto 2019-01-31 um 18 43 35

@solverat
Copy link
Contributor Author

solverat commented Feb 7, 2019

@dpfaffenbauer: final changes:

Renaming

Rename Package to ProductQuantityPriceRules
Rename * ranges to quantity ranges

Tests

-> All Tests with Volume Calculator

  • Scenario: Add a quantity range new price => range price needs to be at "[new price]")
  • Scenario: Add a quantity range with amount decrease (20,-) => base product, 50,-. => range price needs to be at 30,-
  • Scenario: Add a quantity range with amount increase (20,-) => base product, 50,-. => range price needs to be at 70,-
  • Scenario: Add a quantity range with a percentaeg decrease (10%) (base product, 50,- => range price needs to be at 45,-)
  • Scenario: Add a quantity range with a percentaeg increase (10%) (base product, 50,- => range price needs to be at 55,-)
  • Scenario: Add a quantity range with amount decrease (20,-) => base product, 50,- plus specific price rule (store => A, new price = 40,-) => range price needs to be at 20,-
  • Scenario: Add multiple quantity price rules with different conditions =>only the highest prioritized rule should be shown

@solverat solverat changed the title Tier Pricing Quantity Price Rules (Tier Pricing) Feb 7, 2019
@dpfaffenbauer
Copy link
Member

tests are done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants