Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owasp/modsecurity-crs:nginx malforms JS objects since release/20250127 #329

Open
gtaws opened this issue Feb 4, 2025 · 3 comments
Open

Comments

@gtaws
Copy link

gtaws commented Feb 4, 2025

I don't know if this is the right place yet, and I'll update the issue after I get home, but I currently use owasp/modsecurity-crs:nginx in front of Vaultwarden to guard my password manager for little over a year now, and has not given me isssues until release/20250127. Currently, it cannot render pages from Vaultwarden as the JS response seems to be malformed, repeatedly rendering the final chunk of output, but not the rest. Turning on debug logging seems to indicate multiple messages showing that the JS output won't be appended as the content won't be inspected, but no errors. I have to turn off modsecurity inside conf.d/modsecurity.conf for nginx to render Vaultwarden correctly for this release. Rolling back to release/20250105 also fixes the issue. Please let me know what else I need to turn on to either help triage or remediate the issue. I can also attach example correct and broken responses and HAR files later if that helps. This all happens on the login page, so I think no confidential data will appear in the HAR. This issue also occurs in release/20250201.

@fzipi
Copy link
Member

fzipi commented Feb 4, 2025

It is weird that is still happens with the latest release, as we reverted to a well known version of the modsecurity-nginx build (1.0.3). Can you really confirm it does not work again using release/20250201.?

@gtaws
Copy link
Author

gtaws commented Feb 4, 2025

Yup still happening. Simply switched tags from 4.10.0-nginx-202501050801 to 4.11.0-nginx-202502011102 in docker compose with no config changes will let the container come up and seemingly ready to serve pages, but the JS objects come back malformed, although HTML and CSS objects come back fine, I think. I can't really tell if it's actually ok as the browser can't actually render the page correctly, but the source looks OK for those objects. let me know what I should turn on or submit to help triage this.

@theseion
Copy link
Contributor

theseion commented Feb 5, 2025

That's very weird. @fichte do you see the same? I can check tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants