Update to ostree-ext 0.7, add new container-encapsulate
#3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
With this try e.g. |
5be6065 to
14150dc
Compare
|
Demos: FCOS: I've uploaded that to quay.io/cgwalters/fcos-chunked |
dc76688 to
993418d
Compare
2e9ecbb to
86f9375
Compare
c0ff985 to
b06b741
Compare
d084970 to
0893ca4
Compare
|
/test all |
0893ca4 to
257dfe3
Compare
|
/test all |
1 similar comment
|
/test all |
1395db8 to
b8a1786
Compare
|
/test all |
25f1507 to
85f8727
Compare
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Mar 30, 2022
This *opts in* to using coreos/rpm-ostree#3478 so we can safely ratchet in the change, and more easily test in in non-production CI configurations but still using coreos-assembler.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Mar 30, 2022
This *opts in* to using coreos/rpm-ostree#3478 so we can safely ratchet in the change, and more easily test in in non-production CI configurations but still using coreos-assembler.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Mar 31, 2022
This *opts in* to using coreos/rpm-ostree#3478 so we can safely ratchet in the change, and more easily test in in non-production CI configurations but still using coreos-assembler.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Mar 31, 2022
This *opts in* to using coreos/rpm-ostree#3478 so we can safely ratchet in the change, and more easily test in in non-production CI configurations but still using coreos-assembler.
jlebon
pushed a commit
to coreos/coreos-assembler
that referenced
this pull request
Apr 1, 2022
This *opts in* to using coreos/rpm-ostree#3478 so we can safely ratchet in the change, and more easily test in in non-production CI configurations but still using coreos-assembler.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Apr 4, 2022
This requires ostreedev/ostree-rs-ext#275 When `deploy-via-container: true` is used in combination with the new `rpm-ostree container-encapsulate` from coreos/rpm-ostree#3478 We need to use the ostree-container synthetic merge commit to find the deployment. (Actually, what we want is something more like `ostree admin status --json`, or I guess for now `rpm-ostree status --json` to work offline; but for now this is good too)
69617ec to
250e68e
Compare
jlebon
pushed a commit
to coreos/coreos-assembler
that referenced
this pull request
Apr 4, 2022
This requires ostreedev/ostree-rs-ext#275 When `deploy-via-container: true` is used in combination with the new `rpm-ostree container-encapsulate` from coreos/rpm-ostree#3478 We need to use the ostree-container synthetic merge commit to find the deployment. (Actually, what we want is something more like `ostree admin status --json`, or I guess for now `rpm-ostree status --json` to work offline; but for now this is good too)
The headlining feature here is ostreedev/ostree-rs-ext#123 which adds support for "chunked ostree". We gain a new `rpm-ostree container-encapsulate` option which is like `ostree container encapsulate`, but generates chunked images using the RPM database. And on the client side, we now know how to handle incremental updates - chunks that haven't changed won't be redownloaded.
250e68e to
ac3d61b
Compare
container-encapsulate
Hmmmm. This stack trace implies to me the tokio handle code threading has been buggy for quite a while. But I don't understand why it's not always crashing. |
|
/retest |
|
OK this one died in the compose tests, but it can't really break those. I'd like to get this in for the next release, any review takers? |
|
/override continuous-integration/jenkins/pr-merge |
|
@cgwalters: Overrode contexts on behalf of cgwalters: continuous-integration/jenkins/pr-merge In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jlebon
approved these changes
Apr 6, 2022
| @@ -954,6 +954,7 @@ get_refts_for_rootfs (const char *rootfs, GLnxTmpDir *tmpdir) | |||
| gboolean | |||
| rpmostree_get_refts_for_commit (OstreeRepo *repo, const char *ref, RpmOstreeRefTs **out_ts, | |||
| GCancellable *cancellable, GError **error) | |||
|
|
|||
There was a problem hiding this comment.
Minor/optional: extraneous blank line.
| Ok(()) | ||
| } | ||
|
|
||
| fn gv_nevra_to_string(pkg: &glib::Variant) -> String { |
There was a problem hiding this comment.
Pretty sure we have this already on the C side. Might be worth making this public and moving over those callers.
|
Definitely re CI...I'm trying to figure out too how to actually share that across repos. But CI does cover the not-split case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The headlining feature here is ostreedev/ostree-rs-ext#123
which adds support for "chunked ostree".
We gain a new
rpm-ostree container-encapsulateoption whichis like
ostree container encapsulate, but generates chunkedimages using the RPM database.
And on the client side, we now know how to handle incremental
updates - chunks that haven't changed won't be redownloaded.