Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't use add-files in treefile with latest rpm-ostree #1582

Closed
cristifalcas opened this issue Sep 26, 2018 · 1 comment
Closed

can't use add-files in treefile with latest rpm-ostree #1582

cristifalcas opened this issue Sep 26, 2018 · 1 comment
Labels

Comments

@cristifalcas
Copy link

Host system details
Fedora 28, script is run in a privileged container

Provide the output of rpm-ostree status.
rpm-ostree status
error: This system was not booted via libostree; cannot operate

Expected vs actual behavior
Seems that "rpm-ostree compose tree" tries to go twice over add-files.

.........
Mutating /usr/lib/os.release.d/os-release-atomichost
Adding file 'usr/etc/pki/ca-trust/source/anchors/extra_ca.pem'
Adding file 'usr/etc/ssh/sshd_config'
Adding file 'usr/etc/sudoers'
Adding file 'usr/etc/systemd/system/dev-xvdz.swap'
Adding file 'usr/etc/sysconfig/docker'
Adding file 'usr/etc/sysconfig/docker-network'
Adding file 'usr/etc/sysconfig/docker-storage-setup'
Adding file 'usr/etc/containers/registries.conf'
Adding file 'usr/etc/cloudinit_dbus.te'
Adding file 'usr/etc/sshd_curl.te'
Adding file 'usr/etc/systemd_write_etc.te'
Adding file 'usr/bin/cfssl'
Adding file 'usr/bin/cfssljson'
Adding file 'usr/bin/helm'
Adding file 'usr/etc/systemd/system/kubelet.service.d/20-extra-args.conf'
Adding file 'usr/bin/etcd_readd_member.sh'
Adding file 'usr/etc/profile.d/custom_aliases.sh'
Adding file 'usr/bin/helm_install'
Adding file 'usr/bin/init_docker.sh'
Adding file 'usr/bin/init_instance.sh'
Adding file 'usr/etc/sysctl.d/01-kubernetes.conf'
Adding file 'usr/etc/flannel.te'
Adding file 'usr/etc/certs_dir.te'
Adding file 'usr/etc/pki/ca-trust/source/anchors/extra_ca.pem'
error: Postprocessing: Copying file 'ca/extra_ca.pem' into target: linkat: File exists

Expected:
Should be able to use add-files

Steps to reproduce it

Try to use "rpm-ostree compose tree" version 2018.8-1.fc28 with a treefile that has add-files. This will fail with:

error: Postprocessing: Copying file 'ca/extra_ca.pem' into target: linkat: File exists

Downgrade to 2018.4-1.fc28 and do the same thing again. This time the build is successful.

@cgwalters cgwalters added the bug label Sep 26, 2018
@jlebon
Copy link
Member

jlebon commented Oct 22, 2018

OK, just verified that this is fixed in master. It was likely fixed by #1552, before which we parsed the first treefile twice resulting in doubling theadd-files array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants