Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust for the change to running NetworkManager via systemd in the initrd #842

Closed
dustymabe opened this issue May 24, 2021 · 5 comments · Fixed by coreos/fedora-coreos-config#1068
Closed

adjust for the change to running NetworkManager via systemd in the initrd #842

dustymabe opened this issue May 24, 2021 · 5 comments · Fixed by coreos/fedora-coreos-config#1068
Assignees
@dustymabe
Labels
jira for syncing to jira kind/bug

Comments

@dustymabe
Copy link
Member

In dracutdevs/dracut#1281 the network-manager dracut module was updated to run NM via a systemd unit and not as part of dracut's initqueue.

Since the way we have networking (more precisely, networking configuration) set up in the initramfs is quite fragile, we need to investigate the implications here and adjust our strategies
accordingly.

I thought I had more time to dig in and review these changes before they came to us, but dracut 054 was tagged recently and is already in Fedora 34, so we need to address it now.
@dustymabe
Copy link
Member Author

Note that this is currently preventing our lockfile bumper from succeeding. We'll freeze on the old version of dracut to get unblocked for now.

@dustymabe dustymabe added the jira for syncing to jira label May 24, 2021
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 24, 2021
@dustymabe
overrides: freeze on dracut-053-5.fc34
f6dab79 
There are some NetworkManager related changes and possibly others
that are causing failures in our bump-lockfile process. We need
to investigate these issues before promoting dracut-054.

coreos/fedora-coreos-tracker#842
@dustymabe dustymabe mentioned this issue May 24, 2021
Merged
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 24, 2021
@dustymabe
overrides: freeze on dracut-053-5.fc34
6281cc1 
There are some NetworkManager related changes and possibly others
that are causing failures in our bump-lockfile process. We need
to investigate these issues before promoting dracut-054.

coreos/fedora-coreos-tracker#842
(cherry picked from commit f6dab79)
@dustymabe dustymabe mentioned this issue May 24, 2021
Merged
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue May 24, 2021
@dustymabe
overrides: freeze on dracut-053-5.fc34
e252ccb 
There are some NetworkManager related changes and possibly others
that are causing failures in our bump-lockfile process. We need
to investigate these issues before promoting dracut-054.

coreos/fedora-coreos-tracker#842
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue May 24, 2021
@dustymabe
overrides: freeze on dracut-053-5.fc34
9c1e11f 
There are some NetworkManager related changes and possibly others
that are causing failures in our bump-lockfile process. We need
to investigate these issues before promoting dracut-054.

coreos/fedora-coreos-tracker#842
(cherry picked from commit f6dab79)
@dustymabe dustymabe self-assigned this Jun 24, 2021
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Jun 24, 2021
@dustymabe
unfreeze dracut, adapt for NM via systemd in initrd
8fa89fb 
Upstream dracut updated NM to run as a systemd service
(with full dbus support) in the initrd in [1]. Adapt our
systemd units to handle this case.

This should still work fine for RHCOS because we still have
`Before=dracut-initqueue.service`, which can be dropped when
everyone is on dracut 0.54+.

Fixes: coreos/fedora-coreos-tracker#842
@dustymabe dustymabe mentioned this issue Jun 24, 2021
Merged
@dustymabe
Copy link
Member Author

At least one bit of fallout is that teaming no longer works: potential fix in dracutdevs/dracut#1547

Here is a PR to track the changes we need to make to get this in: coreos/fedora-coreos-config#1068

@dustymabe
Copy link
Member Author

One other bit of fallout.. ignition-fetch.service has After=network.target to properly wait. We need nm-initrd.service to pull in network.target (dracutdevs/dracut#1548). Otherwise things like ignition.config.url=https:// might not work right.

@dustymabe dustymabe mentioned this issue Jun 28, 2021
Merged
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Jul 9, 2021
@dustymabe
unfreeze dracut, adapt for NM via systemd in initrd
a437c0c 
Upstream dracut updated NM to run as a systemd service
(with full dbus support) in the initrd in [1]. Adapt our
systemd units to handle this case.

This should still work fine for RHCOS because we still have
`Before=dracut-initqueue.service`, which can be dropped when
everyone is on dracut 0.54+.

Fixes: coreos/fedora-coreos-tracker#842
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Jul 9, 2021
@dustymabe
overrides: fast-track dracut-055-3.fc34
2dffb3c 
Contains upstream fixes needed to get NM running via systemd+dbus
in the initramfs without issues.

- dracutdevs/dracut#1547
- dracutdevs/dracut#1548
- dracutdevs/dracut#1552

Needed to get dracut unfrozen:
coreos/fedora-coreos-tracker#842 (comment)
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Jul 9, 2021
@dustymabe
unfreeze dracut, adapt for NM via systemd in initrd
2a30fec 
Upstream dracut updated NM to run as a systemd service
(with full dbus support) in the initrd in [1]. Adapt our
systemd units to handle this case.

This should still work fine for RHCOS because we still have
`Before=dracut-initqueue.service`, which can be dropped when
everyone is on dracut 0.54+.

Fixes: coreos/fedora-coreos-tracker#842
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Jul 9, 2021
@dustymabe
overrides: fast-track dracut-055-3.fc34
b0c857c 
Contains upstream fixes needed to get NM running via systemd+dbus
in the initramfs without issues.

- dracutdevs/dracut#1547
- dracutdevs/dracut#1548
- dracutdevs/dracut#1552

Needed to get dracut unfrozen:
coreos/fedora-coreos-tracker#842 (comment)
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue Jul 9, 2021
@dustymabe
unfreeze dracut, adapt for NM via systemd in initrd
1aa60d9 
Upstream dracut updated NM to run as a systemd service
(with full dbus support) in the initrd in [1]. Adapt our
systemd units to handle this case.

This should still work fine for RHCOS because we still have
`Before=dracut-initqueue.service`, which can be dropped when
everyone is on dracut 0.54+.

Fixes: coreos/fedora-coreos-tracker#842
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue Jul 9, 2021
@dustymabe
overrides: fast-track dracut-055-3.fc34
85193e3 
Contains upstream fixes needed to get NM running via systemd+dbus
in the initramfs without issues.

- dracutdevs/dracut#1547
- dracutdevs/dracut#1548
- dracutdevs/dracut#1552

Needed to get dracut unfrozen:
coreos/fedora-coreos-tracker#842 (comment)
@dustymabe dustymabe added status/pending-testing-release Fixed upstream. Waiting on a testing release. status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. and removed status/pending-testing-release Fixed upstream. Waiting on a testing release. labels Jul 9, 2021
@dustymabe
Copy link
Member Author

The fix for this went into testing stream release 34.20210711.2.0. Please try out the new release and report issues.

@dustymabe
Copy link
Member Author

The fix for this went into stable stream release 34.20210711.3.0.

@dustymabe dustymabe removed the status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. label Aug 9, 2021
@dustymabe dustymabe changed the title adjust for the change to running NM via systemd in the initrd adjust for the change to running NetworkManager via systemd in the initrd Aug 30, 2021
@dustymabe dustymabe mentioned this issue Aug 30, 2021
Closed
@dustymabe dustymabe mentioned this issue Sep 24, 2021
Open
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@dustymabe @HuijingHei
overrides: freeze on dracut-053-5.fc34
d3da56a 
There are some NetworkManager related changes and possibly others
that are causing failures in our bump-lockfile process. We need
to investigate these issues before promoting dracut-054.

coreos/fedora-coreos-tracker#842
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@dustymabe @HuijingHei
unfreeze dracut, adapt for NM via systemd in initrd
3eeb255 
Upstream dracut updated NM to run as a systemd service
(with full dbus support) in the initrd in [1]. Adapt our
systemd units to handle this case.

This should still work fine for RHCOS because we still have
`Before=dracut-initqueue.service`, which can be dropped when
everyone is on dracut 0.54+.

Fixes: coreos/fedora-coreos-tracker#842
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@dustymabe @HuijingHei
overrides: fast-track dracut-055-3.fc34
788c259 
Contains upstream fixes needed to get NM running via systemd+dbus
in the initramfs without issues.

- dracutdevs/dracut#1547
- dracutdevs/dracut#1548
- dracutdevs/dracut#1552

Needed to get dracut unfrozen:
coreos/fedora-coreos-tracker#842 (comment)
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@dustymabe @HuijingHei
overrides: freeze on dracut-053-5.fc34
a213ba2 
There are some NetworkManager related changes and possibly others
that are causing failures in our bump-lockfile process. We need
to investigate these issues before promoting dracut-054.

coreos/fedora-coreos-tracker#842
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@dustymabe @HuijingHei
unfreeze dracut, adapt for NM via systemd in initrd
2b95e09 
Upstream dracut updated NM to run as a systemd service
(with full dbus support) in the initrd in [1]. Adapt our
systemd units to handle this case.

This should still work fine for RHCOS because we still have
`Before=dracut-initqueue.service`, which can be dropped when
everyone is on dracut 0.54+.

Fixes: coreos/fedora-coreos-tracker#842
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@dustymabe @HuijingHei
overrides: fast-track dracut-055-3.fc34
08f93cb 
Contains upstream fixes needed to get NM running via systemd+dbus
in the initramfs without issues.

- dracutdevs/dracut#1547
- dracutdevs/dracut#1548
- dracutdevs/dracut#1552

Needed to get dracut unfrozen:
coreos/fedora-coreos-tracker#842 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dustymabe dustymabe

Labels
jira for syncing to jira kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unfreeze dracut, adapt for NM via systemd in initrd dustymabe/fedora-coreos-config
1 participant
@dustymabe