From 7b8e1f6e19aae41aa8561e3fda7ee6443ed2fc0e Mon Sep 17 00:00:00 2001 From: Jonathan Lebon Date: Tue, 10 Oct 2023 16:34:31 -0400 Subject: [PATCH] grub.cfg: drop `set pager=1` This was in the very first commit that added a GRUB config to this repo. If set, it causes GRUB to pause output if the screen is full of messages until the user presses a key. That's just incompatible with automation, so nuke it. Any warnings from GRUB should end up in the serial console logs still. One way this can happen is if booting from multipath. GRUB tries each path in turn until it can read from it. For each tried path that's non- optimized, it'll log a message. So if the device has a large enough number of paths, we can trigger the pager functionality and hang boot. Probably fixes: https://issues.redhat.com/browse/OCPBUGS-20123 --- src/grub.cfg | 1 - 1 file changed, 1 deletion(-) diff --git a/src/grub.cfg b/src/grub.cfg index 199720657d..50db863054 100644 --- a/src/grub.cfg +++ b/src/grub.cfg @@ -1,4 +1,3 @@ -set pager=1 # petitboot doesn't support -e and doesn't support an empty path part if [ -d (md/md-boot)/grub2 ]; then # fcct currently creates /boot RAID with superblock 1.0, which allows