Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.7] download-extensions: Strip out user.* xattrs #2406

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

cgwalters
Copy link
Member

xref BZ https://bugzilla.redhat.com/show_bug.cgi?id=2000195

librepo writes these xattrs, but unfortunately Linux tmpfs
doesn't support user.* xattrs. And the OpenShift MCO
falls back to doing podman cp in some cases, which fails
when these xattrs are present.

Since the xattrs are just cache data and not functional,
just strip them out.

Closes: #2401

@cgwalters cgwalters added the branch/rhcos PR against the rhcos branch label Sep 2, 2021
xref BZ https://bugzilla.redhat.com/show_bug.cgi?id=2000195

librepo writes these xattrs, but unfortunately Linux `tmpfs`
doesn't support `user.*` xattrs.  And the OpenShift MCO
falls back to doing `podman cp` in some cases, which fails
when these xattrs are present.

Since the xattrs are just cache data and not functional,
just strip them out.

Closes: coreos#2401
@cgwalters cgwalters force-pushed the 4.7-strip-user-xattrs branch from 4b37dd8 to df26e34 Compare September 2, 2021 15:26
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but LGTM

@cgwalters
Copy link
Member Author

CI doesn't work on branches yet
/override cntinuous-integration/jenkins/pr-merge

@openshift-ci
Copy link

openshift-ci bot commented Sep 2, 2021

@cgwalters: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • cntinuous-integration/jenkins/pr-merge

Only the following contexts were expected:

  • continuous-integration/jenkins/pr-merge

In response to this:

CI doesn't work on branches yet
/override cntinuous-integration/jenkins/pr-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member Author

/override continuous-integration/jenkins/pr-merge

@openshift-ci
Copy link

openshift-ci bot commented Sep 2, 2021

@cgwalters: Overrode contexts on behalf of cgwalters: continuous-integration/jenkins/pr-merge

In response to this:

/override continuous-integration/jenkins/pr-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/rhcos PR against the rhcos branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants