kola: teach upgrades about oci-archive #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
Then in turn this blocks on a new rpm-ostree release since it hits which is fixed by coreos/rpm-ostree#2993 |
|
This is blocked on newer rpm-ostree which is presently blocked waiting for once-a-day bodhi and once-a-day FCOS builds. |
That's part of the reason why we built ourselves the ability to fast-track things. We did it multiple times just yesterday. |
|
OK, I manually built a newer rawhide image and this is now tested and working! |
|
(CI here will test the non-ostree-container path, which should also continue to work, so this shouldn't break anything) |
Part of coreos/fedora-coreos-tracker#812 The code here is unfortunately actually *more* complicated, but that's due to an ostree/ostree-ext bug. It was easier to use `sudo` for everything instead of doing the
jlebon
approved these changes
Jul 22, 2021
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Sep 1, 2021
I forgot that we forked the upgrade tests between FCOS/RHCOS when doing coreos#2300 The ugly hack here is to downconvert the oci image on the kola container side to the old tar format, because the rpm-ostree in RHEL8 is too old to natively accept the ociarchive. Once that is fixed, (which will be helped by us testing this end-to-end) then this code will get nicer.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Sep 2, 2021
I forgot that we forked the upgrade tests between FCOS/RHCOS when doing coreos#2300 The ugly hack here is to downconvert the oci image on the kola container side to the old tar format, because the rpm-ostree in RHEL8 is too old to natively accept the ociarchive. Once that is fixed, (which will be helped by us testing this end-to-end) then this code will get nicer.
cgwalters
added a commit
that referenced
this pull request
Sep 3, 2021
I forgot that we forked the upgrade tests between FCOS/RHCOS when doing #2300 The ugly hack here is to downconvert the oci image on the kola container side to the old tar format, because the rpm-ostree in RHEL8 is too old to natively accept the ociarchive. Once that is fixed, (which will be helped by us testing this end-to-end) then this code will get nicer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of coreos/fedora-coreos-tracker#812
The code here is unfortunately actually more complicated,
but that's due to an ostree/ostree-ext bug.
It was easier to use
sudofor everything instead of doing the