cmd-koji-upload: tag brew builds #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test sanity |
1 similar comment
|
/test sanity |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
CI is failing on Which I think can be solved if the PR is rebased to pick up - #2293 |
Yeah, I rebased locally and was able to build |
The tag passed to cmd-koji-upload was only verified as a valid tag but never used to tag builds. Lets start tagging the builds if the principle has permissions to do so.
|
rebased 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tag passed to cmd-koji-upload was only verified as a valid tag but
never used to tag builds. Lets start tagging the builds if the principle
has permissions to do so.
I couldn't actually test the tagging because the principle I use does not
have permissions to tag builds.