Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-fast: propagate/include metadata #1964

Open
cgwalters opened this issue Dec 10, 2020 · 2 comments
Open

build-fast: propagate/include metadata #1964

cgwalters opened this issue Dec 10, 2020 · 2 comments

Comments

@cgwalters
Copy link
Member

ostree has nice flexible support for injecting metadata into commits. Cool. We've been extensively using it in various ways, e.g coreos-assembler injects basearch and rpm-ostree injects the initramfs-args.

cosa build-fast omits all that stuff. One noticeable side effect of missing the basearch is that zincati goes into a start-die-restart loop (should probably fix cosa to have "this is a fastbuild" flag or something and zincati gracefully shuts down if so?). The only real harm is the spam in the journal, but still.

And a side effect of missing the initramfs-args is that testing rpm-ostree changes in a cosa build-fast and then testing replacing the kernel in there will end up generating a broken initramfs (this took me longer than it should have to figure out, I got distracted by thinking it was selinux because for some reason we're getting a new denial in 33 when rebuilding the initramfs client side).

(I use cosa build-fast a lot)

@cgwalters
Copy link
Member Author

xref coreos/rpm-ostree#2343 for the denial

@jlebon
Copy link
Member

jlebon commented Jan 4, 2024

This is still relevant I think, though specifically in the initramfs case, I think that was fixed with the recent changes in rpm-ostree to use the treefile instead IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants