From 6cb9da322a0d6b117a7c620efb668836a93a042b Mon Sep 17 00:00:00 2001 From: Jose Tomas Robles Hahn Date: Tue, 28 Jan 2025 19:47:01 -0300 Subject: [PATCH] fix: Python dependency sync check is never executed in CI/CD workflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The step “Check that compiled Python dependency manifests are up-to-date with their sources” is supposed to run only for the lowest supported Python version (currently 3.8). However, commit 751adb045e99946adb1ea447e4344b4281d65900 inadvertently disabled this step for all Python versions because of an incorrect string comparison (`3.8.` is not a substring of `3.8`). --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 6c651cc9..4862e961 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -138,7 +138,7 @@ jobs: - name: Check that compiled Python dependency manifests are up-to-date with their sources # FIXME: There are issues related to testing with multiple Python versions. - if: ${{ startsWith(matrix.python_version, '3.8.') }} + if: ${{ startsWith(steps.set_up_python.outputs.python-version, '3.8.') }} run: | source "$PYTHON_VIRTUALENV_ACTIVATE" make python-deps-sync-check