Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments are not parsed #728

Closed
rtetley opened this issue Feb 14, 2024 · 0 comments · Fixed by #755
Closed

Comments are not parsed #728

rtetley opened this issue Feb 14, 2024 · 0 comments · Fixed by #755
Labels
bug Something isn't working

Comments

@rtetley
Copy link
Collaborator

rtetley commented Feb 14, 2024

Currently, the parser does not handle comments. This causes havoc in many cases:

  • When large files have a lot of comments this causes performance issues
  • When lines are commented or uncommented this creates very buggy document states

This is linked to coq/coq#12413 and should be first fixed upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parsing comments coq/vscoq
1 participant
@rtetley