Skip to content
This repository has been archived by the owner on Dec 22, 2020. It is now read-only.

Fix CI #17

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Fix CI #17

merged 1 commit into from
Nov 27, 2020

Conversation

vincentchalamon
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT

@vincentchalamon vincentchalamon self-assigned this Nov 25, 2020
@vincentchalamon vincentchalamon linked an issue Nov 25, 2020 that may be closed by this pull request
Use composer PHP >= instead of ^ #16
Closed
@vincentchalamon vincentchalamon force-pushed the fix/ci branch 3 times, most recently from 0cdcd85 to 1017785 Compare November 25, 2020 12:44
@chalasr
Copy link

chalasr commented Nov 25, 2020

Note that Symfony 3.4 is EOL and will not get security fixes anymore as of the end of this month (i.e. in a week or so).
You may want to drop the doctrine/cache-bundle dependency (deprecated for symfony 4.4+ in favor of symfony/cache pools, it won't be PHP 8 compatible, see doctrine/DoctrineCacheBundle#156).

@vincentchalamon vincentchalamon force-pushed the fix/ci branch 9 times, most recently from 6cd4631 to 9c3d113 Compare November 27, 2020 13:33
@vincentchalamon vincentchalamon merged commit b9b7a04 into master Nov 27, 2020
@vincentchalamon vincentchalamon deleted the fix/ci branch November 27, 2020 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@vincentchalamon vincentchalamon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use composer PHP >= instead of ^
2 participants
@vincentchalamon @chalasr