-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a compilation error in pkg/machine/config.go #21621
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
1 similar comment
LGTM |
/hold |
Commit c524da2 has merged the outcome of two individually tested PRs, resulting in a semantic conflict. [NO NEW TESTS NEEDED] Signed-off-by: Miloslav Trmač <mitr@redhat.com>
f0ba6bb
to
2102a9c
Compare
New changes are detected. LGTM label has been removed. |
The change is to add https://github.com/containers/podman/pull/21621/checks?check_run_id=21490899704 fails, though, building the HEAD commit. It might be safest to just ignore that failure, rather than disable the check and then risk forgetting to reenable… |
Force-pushed to fix main. Closing as this is no longer necessary. |
Commit c524da2 has merged the outcome of two individually tested PRs, resulting in a semantic conflict.
[EDIT: that was #21573]
Does this PR introduce a user-facing change?