Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if vm exists in hyperv already #21603

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

baude
Copy link
Member

@baude baude commented Feb 10, 2024

Fix a bug where if a vm exists, created by some other process/user, and you attempt to make a podman machine with the same name.

Does this PR introduce a user-facing change?

None

Copy link
Contributor

openshift-ci bot commented Feb 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2024
@n1hility
Copy link
Member

LGTM other than the import error

@baude baude force-pushed the hypervfailifvmexists branch 2 times, most recently from 2997bec to c8c40a0 Compare February 10, 2024 19:40
Fix a bug where if a vm exists, created by some other process/user, and
you attempt to make a podman machine with the same name.

Signed-off-by: Brent Baude <bbaude@redhat.com>
@baude baude force-pushed the hypervfailifvmexists branch from c8c40a0 to 2a61998 Compare February 10, 2024 20:49
@n1hility
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7c7b443 into containers:main Feb 11, 2024
84 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label May 12, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. machine release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants