-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforcing mac tests #21562
Merged
openshift-merge-bot
merged 3 commits into
containers:main
from
cevich:enforcing_mac_tests_again
Feb 12, 2024
Merged
Enforcing mac tests #21562
openshift-merge-bot
merged 3 commits into
containers:main
from
cevich:enforcing_mac_tests_again
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
d84d143
to
f7e35b5
Compare
f7e35b5
to
59b92b3
Compare
d77487d
to
e678b05
Compare
we were fighting a flake earlier, so the mac test was removed again and the suspected commit was removed. this turns the test back on so we can see if we pass cleanly. [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <bbaude@redhat.com>
Co-authored-by: Chris Evich <cevich@redhat.com> Signed-off-by: Brent Baude <bbaude@redhat.com>
Followup to containers#21551 Note: Fixed indentation of podman-machine mac task. Signed-off-by: Chris Evich <cevich@redhat.com>
e678b05
to
00180bd
Compare
rebase please |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cevich
added a commit
to cevich/podman
that referenced
this pull request
Feb 13, 2024
**Depends on:** - containers#21551 - containers#21562 Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
added a commit
to cevich/podman
that referenced
this pull request
Feb 13, 2024
**Depends on:** - containers#21551 - containers#21562 - containers#21564 Signed-off-by: Chris Evich <cevich@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
lgtm
Indicates that a PR is ready to be merged.
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
release-note-none
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #21551
Does this PR introduce a user-facing change?