Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforcing mac tests #21562

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

cevich
Copy link
Member

@cevich cevich commented Feb 8, 2024

Depends on #21551

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none labels Feb 8, 2024
@cevich cevich changed the title Enforcing mac tests again [WIP] Enforcing mac tests again Feb 8, 2024
@cevich cevich mentioned this pull request Feb 8, 2024
@cevich cevich changed the title [WIP] Enforcing mac tests again [WIP] Enforcing mac tests Feb 8, 2024
@cevich cevich force-pushed the enforcing_mac_tests_again branch from d84d143 to f7e35b5 Compare February 8, 2024 14:43
@cevich cevich marked this pull request as ready for review February 8, 2024 14:43
@cevich cevich marked this pull request as draft February 8, 2024 14:57
@cevich cevich force-pushed the enforcing_mac_tests_again branch from f7e35b5 to 59b92b3 Compare February 8, 2024 15:13
@cevich cevich force-pushed the enforcing_mac_tests_again branch 2 times, most recently from d77487d to e678b05 Compare February 8, 2024 21:51
baude and others added 3 commits February 10, 2024 13:32
we were fighting a flake earlier, so the mac test was removed again and
the suspected commit was removed.  this turns the test back on so we can
see if we pass cleanly.

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <bbaude@redhat.com>
Co-authored-by: Chris Evich <cevich@redhat.com>
Signed-off-by: Brent Baude <bbaude@redhat.com>
Followup to containers#21551

Note: Fixed indentation of podman-machine mac task.

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich cevich force-pushed the enforcing_mac_tests_again branch from e678b05 to 00180bd Compare February 12, 2024 14:28
@cevich cevich changed the title [WIP] Enforcing mac tests Enforcing mac tests Feb 12, 2024
@cevich cevich marked this pull request as ready for review February 12, 2024 14:30
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2024
@cevich cevich requested a review from baude February 12, 2024 14:31
@baude
Copy link
Member

baude commented Feb 12, 2024

i'm a little worried that this PR will force a rebase on #21597 ... and that PR is harder to rebase for @n1hility ... lets let that one get in first, and then we merge this one. if i have to rebase the PRs i have in the queue, I will ....

@baude
Copy link
Member

baude commented Feb 12, 2024

rebase please

@rhatdan
Copy link
Member

rhatdan commented Feb 12, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2024
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c711d87 into containers:main Feb 12, 2024
86 checks passed
cevich added a commit to cevich/podman that referenced this pull request Feb 13, 2024
**Depends on:**
- containers#21551
- containers#21562

Signed-off-by: Chris Evich <cevich@redhat.com>
cevich added a commit to cevich/podman that referenced this pull request Feb 13, 2024
**Depends on:**
- containers#21551
- containers#21562
- containers#21564

Signed-off-by: Chris Evich <cevich@redhat.com>
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label May 13, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants