Set interface name same as the network_interface name.

[vikas-goel]

When interface_name attribute in containers.conf is set to "device", then set interface names inside containers same as the network_interface names.

If the interface name is set in the user request, then that takes precedence.

Fixes: #21313

Signed-off-by: Vikas Goel vikas.goel@gmail.com

Does this PR introduce a user-facing change? Yes

[openshift-ci]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[TomSweeneyRedHat]

/approved

[TomSweeneyRedHat]

@vikas-goel It looks like you have some syntax errors:

# github.com/containers/podman/v4/libpod
libpod/networking_common.go:470:11: undefined: nicName
libpod/networking_common.go:486:36: undefined: nicName
libpod/networking_common.go:486:81: c.runtime.config.Containers.InterfaceName undefined (type "github.com/containers/common/pkg/config".ContainersConfig has no field or method InterfaceName)
libpod/networking_common.go:487:27: undefined: nicName
libpod/runtime_ctr.go:274:82: ctr.runtime.config.Containers.InterfaceName undefined (type "github.com/containers/common/pkg/config".ContainersConfig has no field or method InterfaceName)
make[1]: *** [Makefile:350: bin/podman] Error 1
make[1]: Leaving directory '/var/tmp/go/src/github.com/containers/podman'
make: *** [Makefile:740: podman-release-amd64.tar.gz] Error 2

[vikas-goel]

@vikas-goel It looks like you have some syntax errors:

# github.com/containers/podman/v4/libpod
libpod/networking_common.go:470:11: undefined: nicName
libpod/networking_common.go:486:36: undefined: nicName
libpod/networking_common.go:486:81: c.runtime.config.Containers.InterfaceName undefined (type "github.com/containers/common/pkg/config".ContainersConfig has no field or method InterfaceName)
libpod/networking_common.go:487:27: undefined: nicName
libpod/runtime_ctr.go:274:82: ctr.runtime.config.Containers.InterfaceName undefined (type "github.com/containers/common/pkg/config".ContainersConfig has no field or method InterfaceName)
make[1]: *** [Makefile:350: bin/podman] Error 1
make[1]: Leaving directory '/var/tmp/go/src/github.com/containers/podman'
make: *** [Makefile:740: podman-release-amd64.tar.gz] Error 2

This is waiting for containers/common#1814 to get merged and promoted.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vikas-goel
Once this PR has been reviewed and has the lgtm label, please assign giuseppe for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vikas-goel]

/retest

[openshift-ci]

@vikas-goel: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vikas-goel]

@rhatdan , @TomSweeneyRedHat , @mheon ,
As this repo is updated to use the latest common repo, can you add /ok-to-test tag to retest this PR?