Move the --farm flag to farm build command #20819
Conversation
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
If you don't have any new tests to add you need to have the [NO NEW TESTS] line in your commit. Can you also add a more descriptive commit message? |
|
@cgiradkar why is this draft? You should only use Draft if you want your PR to run through QE but not be merged. If you would like to have a PR reviewed and merged if it passes tests, do not set it to draft. |
7f6f1e5 to
85e242c
Compare
cmd/podman/farm/build.go
Outdated
| @@ -19,6 +19,7 @@ type buildOptions struct { | |||
| buildOptions common.BuildFlagsWrapper | |||
| local bool | |||
| platforms []string | |||
| Farm string | |||
There was a problem hiding this comment.
This can be private, please switch it to farm.
|
@cgiradkar nice work! You need to make changes to the docs as well |
1cf8146 to
6daa0b4
Compare
The option `farm` which is used to specify the farm to be used, is moved to farm build command from farm command. closes containers#20752 Signed-off-by: Chetan Giradkar <cgiradka@redhat.com>
6daa0b4 to
31df9c2
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgiradkar, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Followup to containers#20819 (move --farm option to podman farm build). Remove the Hidden setting for podman farm, and enable man page cross-checks. Signed-off-by: Ed Santiago <santiago@redhat.com>
closes #20752
Does this PR introduce a user-facing change?