Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up farm-build miscommit #20753

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Clean up farm-build miscommit #20753

merged 1 commit into from
Nov 27, 2023

Conversation

edsantiago
Copy link
Member

@edsantiago edsantiago commented Nov 22, 2023 •
edited
Loading

Followup to #20051, which I didn't review in time.

[NO NEW TESTS NEEDED] -- I tested on my laptop, pinky promise

Signed-off-by: Ed Santiago santiago@redhat.com

None

@edsantiago edsantiago requested a review from umohnani8 November 22, 2023 21:00
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 22, 2023
@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@edsantiago
Copy link
Member Author

Quick reminder that podman farm is special-cased in xref-helpmsgs-manpages because it is a hidden command.

In future updates to farm-build docs, I recommend temp-disabling cmd/podman/farm/farm.go:farmCmd.Hidden = true and manually running hack/xref-helpmsgs-manpages.

@rhatdan
Copy link
Member

rhatdan commented Nov 22, 2023

We should unhide it now. Podman 5.0 is the main branch, so it should be seen.

@rhatdan
Copy link
Member

rhatdan commented Nov 22, 2023

LGTM
But needs a new test.

@edsantiago edsantiago force-pushed the farmbuild_docs_cleanup branch from 823df5b to bdd4e70 Compare November 22, 2023 21:22
@edsantiago
Copy link
Member Author

But needs a new test.

I totally deserved that!

Roger on your unhide, but not in this commit: CI would fail because of #20752, which is more surgery than I want to perform right now.

@mheon
Copy link
Member

mheon commented Nov 22, 2023

LGTM

@rhatdan
Copy link
Member

rhatdan commented Nov 22, 2023

Little things bring me joy, asking @edsantiago to add a test...

Luap99
Luap99 requested changes Nov 23, 2023
View reviewed changes
@edsantiago edsantiago marked this pull request as draft November 23, 2023 12:10
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2023
@lsm5
Copy link
Member

lsm5 commented Nov 27, 2023

/packit copr-build

@edsantiago
Clean up farm-build miscommit
f6b2a13 
Followup to containers#20051, which I didn't review in time.

Signed-off-by: Ed Santiago <santiago@redhat.com>
@edsantiago edsantiago force-pushed the farmbuild_docs_cleanup branch from bdd4e70 to f6b2a13 Compare November 27, 2023 13:25
@edsantiago edsantiago marked this pull request as ready for review November 27, 2023 15:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2023
Luap99
Luap99 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@umohnani8
Copy link
Member

Thanks @edsantiago
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 8e5e060 into containers:main Nov 27, 2023
@edsantiago edsantiago deleted the farmbuild_docs_cleanup branch November 27, 2023 18:33
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Feb 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhatdan rhatdan rhatdan left review comments

@Luap99 Luap99 Luap99 approved these changes

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@umohnani8 umohnani8

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@edsantiago @rhatdan @mheon @lsm5 @umohnani8 @Luap99