Temporarily pull machine images from side repo #13220
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -142,7 +177,28 @@ func getFCOSDownload(imageStream string) (*fcosDownloadInfo, error) { | |||
| logrus.Error(err) | |||
| } | |||
| }() | |||
| if imageStream == podmanTesting { | |||
There was a problem hiding this comment.
I don't understand the need for this, the data we're getting should be...oh no, argh. Right, there's 3 levels of JSON (cosa meta, release json, and stream JSON), and we actually only got the second. I'm so sorry, I messed that up.
Well, it honestly doesn't matter - what matters is the binary can pull it, if we temporarily uglify this code I don't think it's a big deal.
For general context, Brent and I discussed this and I am firmly of the opinion we on CoreOS side (as well as elsewhere) should aim to ditch all our custom JSON long term in favor of OCI artifacts. For more on that, see coreos/fedora-coreos-tracker#828
There was a problem hiding this comment.
wait, this is not pretty? I feel pretty.
Until podman4 is in the fcos trees, we need to pull the machine images from a side repository. There is a hard coded bit that forces the side repo download right now. Simple comment or removal of the bit will revert to normal download behavior. [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <bbaude@redhat.com>
|
LGTM, but I kind of hate that we have no tests for machine so we can't validate this in CI. |
|
I just tried it and it works but there is one problem. Netavark is installed and selected as network backend which is good but aardvark is not installed so dns does not work. |
Until podman4 is in the fcos trees, we need to pull the machine images
from a side repository. There is a hard coded bit that forces the
side repo download right now. Simple comment or removal of the bit will
revert to normal download behavior.
Signed-off-by: Brent Baude bbaude@redhat.com