Fixes for child process monitoring #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to implement proper error handling, we are going to need to also access the singleton child process state. (In the future we should support concurrent blob fetches which would return the `std::fs::File` which can be accessed concurrently/separately from the proxy. But our users aren't doing concurrent fetches yet)
I am seeing the proxy seeming to exit during a request. We need to also monitor the child process while making a request.
Previously I refactored the code to have `impl_request_raw` to check the semver so we could do the child process checking at the same time. But now that that's a default part of the main request flow, clean things up here make the semver call not special.
a151a51 to
8593d1a
Compare
lucab
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take
&mut selfconsistentlyIn order to implement proper error handling, we are going
to need to also access the singleton child process state.
(In the future we should support concurrent blob fetches
which would return the
std::fs::Filewhich can be accessedconcurrently/separately from the proxy. But our users aren't
doing concurrent fetches yet)
Check for child exit during all requests
I am seeing the proxy seeming to exit during a request. We
need to also monitor the child process while making a request.
Use main request method for semver checking
Previously I refactored the code to have
impl_request_rawto check the semver so we could do the child process checking
at the same time. But now that that's a default part of the main
request flow, clean things up here make the semver call not special.
Bump to 0.2.0 for API changes