Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add Azure pipeline support to support IPV6 test. #2031

Closed
Zheaoli opened this issue Feb 20, 2023 · 16 comments
Closed

Proposal: Add Azure pipeline support to support IPV6 test. #2031

Zheaoli opened this issue Feb 20, 2023 · 16 comments

Comments

@Zheaoli
Copy link
Member

Zheaoli commented Feb 20, 2023

What is the problem you're trying to solve

For now, the GHA is not supported IPV6 for the GitHub Hosted Runner yet.

So maybe we need a platform to run an extra IPV6 tests.

Describe the solution you'd like

For now, I recommend the Azure Pipeline. FYI https://azure.microsoft.com/en-us/products/devops/pipelines & https://azure.microsoft.com/en-us/updates/ipv6-for-azure-virtual-network-is-now-generally-available-2/

There are already some open source projects to use Azure Pipeline as CI/CD platform, such as CPython(FYI https://github.com/python/cpython/tree/main/.azure-pipelines)

Additional context

No response

@fahedouch
Copy link
Member

@yuchanns are you blocked by this to test #1558 ?

@yuchanns
Copy link
Contributor

@fahedouch Yes. The proposal is practically for it.

@manugupt1
Copy link
Contributor

I think we should just have an Azure pipeline for ipv6 test only and let everything else run on GHA

@AkihiroSuda
Copy link
Member

wondering if we can just use this
https://github.com/containerd/containerd/blob/e366facb876598d783e07ba6baa2b61e62e6808c/.github/workflows/windows-hyperv-periodic.yml#L20

@marosset
Copy link

CC @lachie83 who manages the Azure sub we run K8s and containerd tests in.

@yuchanns
Copy link
Contributor

yuchanns commented Mar 9, 2023

Kindly ping @lachie83 :-)

@lachie83
Copy link

lachie83 commented Mar 9, 2023

Thanks for the ping. I would like to know a little more about the frequency that these tests will be run, how long they will run for, and what resources you need (eg. single VM and what size?)

@Zheaoli
Copy link
Member Author

Zheaoli commented Mar 10, 2023

Thanks for the ping. I would like to know a little more about the frequency that these tests will be run, how long they will run for, and what resources you need (eg. single VM and what size?)

Thanks for the comment.

Here are the requirement for this project:

  1. each PR should run the test on the Azure IPV6 machine
  2. The total for each test should not be over 20mins.
  3. I think maybe we need two 2C4G machines. cc @AkihiroSuda

Feel free to comment if you got any issues. thanks! @lachie83

@yuchanns
Copy link
Contributor

I think we should just have an Azure pipeline for ipv6 test only and let everything else run on GHA

I shared the same idea as well.

@lachie83
Copy link

Please proceed with adding these tests.

@yuchanns
Copy link
Contributor

@lachie83 We already got a PR (#1558) with requiring IPv6 support.

@lachie83
Copy link

Great! Do you need anything else from me?

@yuchanns
Copy link
Contributor

@lachie83 Yes. In order to run IPv6-related integration tests, I need access to the Azure instance and make it the CI of this repository. As mentioned above said that you are managing the Azure sub to run K8s and containerd tests in, I would like to know what should we do to obtain this capability for nerdctl.

@yuchanns
Copy link
Contributor

yuchanns commented May 4, 2023

ping @lachie83

@AkihiroSuda
Copy link
Member

What's current status of this?
@yuchanns @lachie83

@yuchanns
Copy link
Contributor

Closed as #1558 is merged.

@AkihiroSuda AkihiroSuda closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants