Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting gradients #691

Closed
Mathias-Boulay opened this issue Jan 22, 2025 · 3 comments
Closed

Consider supporting gradients #691

Mathias-Boulay opened this issue Jan 22, 2025 · 3 comments

Comments

@Mathias-Boulay
Copy link

Hello there, I found myself wanting to use gradients for part of my CLI.
In my case, it was the ProgressBar

I desired something like the following:

Image

Since console doesn't support gradients, I took the liberty of creating my own implementation for it (hence the image produced beforehand)

Should I clean up my work and make a PR, or is it not planned to support such a case ?

@djc
Copy link
Member

djc commented Jan 22, 2025

I'm open to reviewing code for this assuming the complexity is pretty self-contained. FWIW I can also review PRs in console so if it makes more sense to keep some of your code in that crate, suggest spreading it across the crates if/where that makes sense.

@Mathias-Boulay
Copy link
Author

Mathias-Boulay commented Jan 22, 2025

Well yeah the code changes were in console only but the color capabilities were also bolstered in the readme of this repository.

I'll probably do a PR "soon" on console then

@Mathias-Boulay
Copy link
Author

@djc Initial PR done, let's move the discussion over there.
console-rs/console#233

@djc djc reopened this Jan 22, 2025
@djc djc closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants