-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirmation should wait for Enter key to be pressed #66
Comments
This should be optional behaviour user can opt in to. |
Every CLI program I've ever used (maybe with one or two exceptions) that's implemented confirmations like this has waited for the Enter key, so I would argue that it should be the default, but if the alternative is not having it at all then I'm fine with it being optional. |
Just noticed this, should really wait for the user to press enter so you have one extra second to think over what you're doing or as @pksunkara wrote, an optional behaviour. |
I've opened a PR in #70. I opted to keep the current behavior as the default since apps using |
Currently the confirmation proceeds immediately on a single key being input, which isn't really inline with conventional CLI design. I'd expect it to wait for Enter to be pressed even when giving an explicit answer.
The text was updated successfully, but these errors were encountered: