Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote without profile fails to read fields #7

Closed
Nr18 opened this issue Jan 24, 2022 · 1 comment
Closed

remote without profile fails to read fields #7

Nr18 opened this issue Jan 24, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@Nr18
Copy link
Collaborator

Nr18 commented Jan 24, 2022

What were you trying to accomplish?

Expected Behavior

When executing the pull-request-codecommit command while using a codecommit::eu-west-1://my-repo remote fails to read the region and repo name.

Current Behavior

Remote: codecommit::eu-west-1://my-repo
Region:
Profile:
Repo:
Branch: main

Possible Solution

Fallback on a default aws profile when no profile is given. This is the same behaviour as the cli. Or use the AWS_PROFILE environment variable.

Steps to Reproduce (for bugs)

  1. Create a repo with codecommit::eu-west-1://my-repo as a remote.
  2. Execute the pull-request-codecommit command.

Environment

  • pull-request-codecommit version used: 0.1.0
  • Debugging logs N/A
@Nr18 Nr18 added the bug Something isn't working label Jan 24, 2022
Nr18 pushed a commit that referenced this issue Jan 25, 2022
fix: support fallback to default profile and region
13bb074 
By moving the remote logic to its own class it allows us to encapsulate the behaviour. And making it easier to extend the behaviour.

Fixes issue #7
Nr18 pushed a commit that referenced this issue Jan 25, 2022
fix: support schema notation without a region
debceaf 
Support both `codecommit://` and `codecommit::://` notations.

Issue: #7
@Nr18 Nr18 mentioned this issue Jan 25, 2022
Merged
3 tasks
Nr18 pushed a commit that referenced this issue Jan 25, 2022
fix: support fallback to default profile and region (#11)
52389cc 
* fix: support fallback to default profile and region

By moving the remote logic to its own class it allows us to encapsulate the behaviour. And making it easier to extend the behaviour.
Support both `codecommit://` and `codecommit::://` notations.

Fixes issue #7
@Nr18
Copy link
Collaborator Author

Nr18 commented Jan 27, 2022

Fixed in v0.2.0

@Nr18 Nr18 closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Nr18