From 16d208a802445e789168e98b97a2cb81b302bd4e Mon Sep 17 00:00:00 2001 From: Sudesh Date: Thu, 9 Jan 2025 21:37:10 +0530 Subject: [PATCH] [review] change javaDoc + revert un-required addition --- .../internal/streaming/BufferedTopicPartitionChannel.java | 6 +++--- .../internal/streaming/TopicPartitionChannelIT.java | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/snowflake/kafka/connector/internal/streaming/BufferedTopicPartitionChannel.java b/src/main/java/com/snowflake/kafka/connector/internal/streaming/BufferedTopicPartitionChannel.java index 8f5304af8..03c713fd4 100644 --- a/src/main/java/com/snowflake/kafka/connector/internal/streaming/BufferedTopicPartitionChannel.java +++ b/src/main/java/com/snowflake/kafka/connector/internal/streaming/BufferedTopicPartitionChannel.java @@ -1310,13 +1310,13 @@ public void insert(SinkRecord kafkaSinkRecord) { } /** - * Get all rows and their offsets. Each map corresponds to one row whose keys are column names - * and values are corresponding data in that column. + * Get all rows and corresponding SinkRecords. Each map corresponds to one row whose keys are + * column names and values are corresponding data in that column. * *

This goes over through all buffered kafka records and transforms into JsonSchema and * JsonNode Check {@link #handleNativeRecord(SinkRecord, boolean)} * - * @return A pair that contains the records and their corresponding offsets + * @return A pair that contains the records and their corresponding original sinkRecords */ @Override public Pair>, List> getData() { diff --git a/src/test/java/com/snowflake/kafka/connector/internal/streaming/TopicPartitionChannelIT.java b/src/test/java/com/snowflake/kafka/connector/internal/streaming/TopicPartitionChannelIT.java index 13ab2c09b..a9dee7a9e 100644 --- a/src/test/java/com/snowflake/kafka/connector/internal/streaming/TopicPartitionChannelIT.java +++ b/src/test/java/com/snowflake/kafka/connector/internal/streaming/TopicPartitionChannelIT.java @@ -737,8 +737,7 @@ private void testInsertRowsWithGaps(boolean withSchematization, boolean useSingl SnowflakeSinkConnectorConfig.setDefaultValues(config); config.put( SnowflakeSinkConnectorConfig.ENABLE_SCHEMATIZATION_CONFIG, - Boolean.toString(withSchematization) - ); + Boolean.toString(withSchematization)); // create tpChannel SnowflakeSinkService service =