From b74f2f4c2de7d8bae416f00e06732a064916b182 Mon Sep 17 00:00:00 2001 From: Walker Carlson Date: Thu, 6 May 2021 14:04:09 -0700 Subject: [PATCH 1/2] change the isError to not use the state --- .../src/main/java/io/confluent/ksql/util/QueryMetadataImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ksqldb-engine/src/main/java/io/confluent/ksql/util/QueryMetadataImpl.java b/ksqldb-engine/src/main/java/io/confluent/ksql/util/QueryMetadataImpl.java index 8b2a8fbaaf13..2b7a592fd40c 100644 --- a/ksqldb-engine/src/main/java/io/confluent/ksql/util/QueryMetadataImpl.java +++ b/ksqldb-engine/src/main/java/io/confluent/ksql/util/QueryMetadataImpl.java @@ -228,7 +228,7 @@ public State getState() { } public boolean isError() { - return getState() == State.ERROR; + return !queryErrors.toImmutableList().isEmpty(); } public String getExecutionPlan() { From fce3f1dc1fbbe063acf26372dee2e747dc6882e7 Mon Sep 17 00:00:00 2001 From: Walker Carlson Date: Tue, 11 May 2021 10:36:49 -0700 Subject: [PATCH 2/2] isError is not used --- .../src/main/java/io/confluent/ksql/util/QueryMetadata.java | 2 -- .../main/java/io/confluent/ksql/util/QueryMetadataImpl.java | 4 ---- 2 files changed, 6 deletions(-) diff --git a/ksqldb-engine/src/main/java/io/confluent/ksql/util/QueryMetadata.java b/ksqldb-engine/src/main/java/io/confluent/ksql/util/QueryMetadata.java index 331bde23e65b..b38b766a6d92 100644 --- a/ksqldb-engine/src/main/java/io/confluent/ksql/util/QueryMetadata.java +++ b/ksqldb-engine/src/main/java/io/confluent/ksql/util/QueryMetadata.java @@ -43,8 +43,6 @@ public interface QueryMetadata { KafkaStreams.State getState(); - boolean isError(); - String getExecutionPlan(); String getQueryApplicationId(); diff --git a/ksqldb-engine/src/main/java/io/confluent/ksql/util/QueryMetadataImpl.java b/ksqldb-engine/src/main/java/io/confluent/ksql/util/QueryMetadataImpl.java index 2b7a592fd40c..d52404de5213 100644 --- a/ksqldb-engine/src/main/java/io/confluent/ksql/util/QueryMetadataImpl.java +++ b/ksqldb-engine/src/main/java/io/confluent/ksql/util/QueryMetadataImpl.java @@ -227,10 +227,6 @@ public State getState() { return kafkaStreams.state(); } - public boolean isError() { - return !queryErrors.toImmutableList().isEmpty(); - } - public String getExecutionPlan() { return executionPlan; }