Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list_votes_by_voter query to voting_contract #78

Closed
ueco-jb opened this issue Feb 4, 2022 · 1 comment · Fixed by #79
Closed

Add list_votes_by_voter query to voting_contract #78

ueco-jb opened this issue Feb 4, 2022 · 1 comment · Fixed by #79
Assignees

Comments

@ueco-jb
Copy link

ueco-jb commented Feb 4, 2022

Follow up of: confio/tgrade-contracts#455

We are trying to unify voting contract's interfaces to this pattern:

Rules {},
Proposal { proposal_id: u64 },
ListProposals {
    start_after: Option<u64>,
    limit: Option<u32>,
},
ReverseProposals {
    start_before: Option<u64>,
    limit: Option<u32>,
},
Vote { proposal_id: u64, voter: String },
ListVotes {
    proposal_id: u64,
    start_after: Option<String>,
    limit: Option<u32>,
},
ListVotesByVoter {
    voter: String,
    start_after: Option<String>,
    limit: Option<u32>,
},
Voter { address: String },
ListVoters {
    start_after: Option<String>,
    limit: Option<u32>,
},
@ueco-jb ueco-jb added breaking-state Storage breaking: Requires migration breaking-api API breaking: Remove, Change (rename, change type), Add non-optional / non-default field labels Feb 4, 2022
@ueco-jb ueco-jb self-assigned this Feb 4, 2022
@BirgitPohl BirgitPohl added this to the 0.6.0 "Patchnet" milestone Feb 4, 2022
@BirgitPohl
Copy link

I'm adding this to Patchnet Milestone because this is where we want to have potential breaking changes and not later.
Let me know if this is incorrect.

@ueco-jb ueco-jb added breaking Breaking changes (API or State) and removed breaking Breaking changes (API or State) breaking-state Storage breaking: Requires migration breaking-api API breaking: Remove, Change (rename, change type), Add non-optional / non-default field labels Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants