Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conekta component #59

Merged
merged 3 commits into from
Jul 10, 2018
Merged

Add conekta component #59

merged 3 commits into from
Jul 10, 2018

Conversation

cone-7
Copy link
Contributor

@cone-7 cone-7 commented Jul 6, 2018

Add the new functionality conekta component.

Eduardo Enriquez and others added 2 commits April 30, 2018 12:31
Why is this change neccesary?

How does it address the issue?

What side effects does this change have?

var conektaSuccessResponseHandler = function(response) {
var $form = $('#conekta-payment-form');
$form.append($('<input type="hidden" name="conektaToken" id="conektaToken" />').val(response.id));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aqui no existe la misma problematica que con woocommerce? de que en lugar de sobreescribir el token apende un input nuevo abajo del existente ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eduenriquez en este caso se hace un submit y se recarga la pagina siempre.

@@ -23,7 +23,7 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*}
<script type="text/javascript" src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>
<script type="text/javascript" src="https://cdn.conekta.io/js/latest/conekta.js"></script>
<script type="text/javascript" src="https://cdn.conekta.io/iframe/latest/conekta-iframe.js"></script>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

por qué estamos usando una versión que no está minificada ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielconekta aun no hay mimificada del iframe y cambiare la de conekta.js.

};

var conektaErrorResponseHandler = function(token) {
var $form = $('#conekta-payment-form');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aquí te está sobrando esa variable no?, no veo que se esté usando, supongo que la querías usar con el prepend del else pero no veo que se haga nada, sería mejor borrarla para que jquery no haga la búsqueda del elemento

@fruizg0302 fruizg0302 merged commit c75ed98 into master Jul 10, 2018
@KrishnaRamos KrishnaRamos deleted the conekta-sdk-beta branch January 21, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants