-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conekta component #59
Conversation
Why is this change neccesary? How does it address the issue? What side effects does this change have?
|
||
var conektaSuccessResponseHandler = function(response) { | ||
var $form = $('#conekta-payment-form'); | ||
$form.append($('<input type="hidden" name="conektaToken" id="conektaToken" />').val(response.id)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aqui no existe la misma problematica que con woocommerce? de que en lugar de sobreescribir el token apende un input nuevo abajo del existente ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eduenriquez en este caso se hace un submit y se recarga la pagina siempre.
views/templates/hook/hook-header.tpl
Outdated
@@ -23,7 +23,7 @@ | |||
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0) | |||
*} | |||
<script type="text/javascript" src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script> | |||
<script type="text/javascript" src="https://cdn.conekta.io/js/latest/conekta.js"></script> | |||
<script type="text/javascript" src="https://cdn.conekta.io/iframe/latest/conekta-iframe.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
por qué estamos usando una versión que no está minificada ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielconekta aun no hay mimificada del iframe y cambiare la de conekta.js.
views/js/tokenize.js
Outdated
}; | ||
|
||
var conektaErrorResponseHandler = function(token) { | ||
var $form = $('#conekta-payment-form'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aquí te está sobrando esa variable no?, no veo que se esté usando, supongo que la querías usar con el prepend del else pero no veo que se haga nada, sería mejor borrarla para que jquery no haga la búsqueda del elemento
Add the new functionality conekta component.